Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adding comparison operator useful in switch or if else code blocks. Currently, the comparisons of the type
ReturnCode A == ReturnCode::RETCODE_X (This is actually of type ReturnCodeValue)are implicitly calling the constructor
ReturnCode::ReturnCode(const fastdds::dds::ReturnCode_t& value)for the right operand of the equality.
This can lead to issues since that constructor is not designed for variables of the type ReturnCodeValue but it is still called since both enums fall back to integers.
A new constructor from type ReturnCodeValue has been added to mitigate this issue
These are the artifacts generated using this patch on eprosimaCI:
Note they all use the suffix "_devutils_retcode_patch"
These are the CI's of the tools that depend on DevUtils running over those artifacts